Harden backend auth, validation and error handling
- Rate limit login (5 attempts/min per IP) with a JSON 429 response - Constant-time password comparison; refuse login if no password is configured - Explicit SameSite=Strict auth cookie; log failed logins with client IP - Stop logging door codes (update log lines and the SMS body) - Replace per-action try/catch -> 400 with a global exception handler (JSON 500) - Return proper statuses: 404 for missing person, 502 for failed lock writes - Validate codes as ASCII digits only (int.TryParse accepted +/-/whitespace) - Validate person name and E.164 phone number; reject sending an unset code - Rename TwiloOptions -> TwilioOptions and fix message typos - Expose Program for integration tests
This commit is contained in:
1 parent
768bcc90e4
commit
d0425c8cb2
38 files changed
+189
-487
No files matched your search
@@ -3,8 +3,11 @@ using Microsoft.AspNetCore.Authentication.Cookies;
|
||||
using Microsoft.AspNetCore.Authorization;
|
||||
using Microsoft.AspNetCore.Cors;
|
||||
using Microsoft.AspNetCore.Mvc;
|
||||
using Microsoft.AspNetCore.RateLimiting;
|
||||
using Microsoft.Extensions.Options;
|
||||
using System.Security.Claims;
|
||||
using System.Security.Cryptography;
|
||||
using System.Text;
|
||||
using YaleAccess.Models;
|
||||
|
||||
namespace YaleAccess.Controllers
|
||||
@@ -15,54 +18,60 @@ namespace YaleAccess.Controllers
|
||||
[Authorize]
|
||||
public class AuthenticationController(IOptions<Models.Options.AuthenticationOptions> authenticationOptions, ILogger<AuthenticationController> logger) : ControllerBase
|
||||
{
|
||||
public const string LoginRateLimitPolicy = "login";
|
||||
|
||||
[HttpPost("login")]
|
||||
[AllowAnonymous]
|
||||
[EnableRateLimiting(LoginRateLimitPolicy)]
|
||||
public async Task<IActionResult> Login([FromBody] string password)
|
||||
{
|
||||
try
|
||||
// Refuse to authenticate at all if no password has been configured
|
||||
string expectedPassword = authenticationOptions.Value.Password;
|
||||
if (string.IsNullOrEmpty(expectedPassword))
|
||||
{
|
||||
// Check if the password is correct
|
||||
if (password != authenticationOptions.Value.Password)
|
||||
{
|
||||
return Unauthorized(new ApiResponse("Incorrect password."));
|
||||
}
|
||||
|
||||
// Log the user in
|
||||
List<Claim> claims = new()
|
||||
{
|
||||
new Claim(ClaimTypes.Name, "YaleAccess")
|
||||
};
|
||||
ClaimsIdentity claimsIdentity = new(claims, CookieAuthenticationDefaults.AuthenticationScheme);
|
||||
ClaimsPrincipal claimsPrincipal = new(claimsIdentity);
|
||||
|
||||
await HttpContext.SignInAsync(CookieAuthenticationDefaults.AuthenticationScheme, claimsPrincipal);
|
||||
|
||||
// Return the response
|
||||
return Ok(new ApiResponse(true));
|
||||
logger.LogError("No authentication password has been configured, refusing all logins.");
|
||||
return StatusCode(StatusCodes.Status500InternalServerError, new ApiResponse("Authentication is not configured."));
|
||||
}
|
||||
catch(Exception ex)
|
||||
|
||||
// Check if the password is correct
|
||||
if (!PasswordMatches(password, expectedPassword))
|
||||
{
|
||||
logger.LogError(ex, "An error occurred logging in.");
|
||||
return BadRequest(new ApiResponse("An error occurred logging in."));
|
||||
logger.LogWarning("Failed login attempt from {RemoteIp}.", HttpContext.Connection.RemoteIpAddress);
|
||||
return Unauthorized(new ApiResponse("Incorrect password."));
|
||||
}
|
||||
|
||||
// Log the user in
|
||||
List<Claim> claims = new()
|
||||
{
|
||||
new Claim(ClaimTypes.Name, "YaleAccess")
|
||||
};
|
||||
ClaimsIdentity claimsIdentity = new(claims, CookieAuthenticationDefaults.AuthenticationScheme);
|
||||
ClaimsPrincipal claimsPrincipal = new(claimsIdentity);
|
||||
|
||||
await HttpContext.SignInAsync(CookieAuthenticationDefaults.AuthenticationScheme, claimsPrincipal);
|
||||
|
||||
// Return the response
|
||||
return Ok(new ApiResponse(true));
|
||||
}
|
||||
|
||||
[HttpPost("logout")]
|
||||
[AllowAnonymous]
|
||||
public async Task<IActionResult> Logout()
|
||||
{
|
||||
try
|
||||
{
|
||||
// Sign the user out
|
||||
await HttpContext.SignOutAsync(CookieAuthenticationDefaults.AuthenticationScheme);
|
||||
// Sign the user out
|
||||
await HttpContext.SignOutAsync(CookieAuthenticationDefaults.AuthenticationScheme);
|
||||
|
||||
return Ok(new ApiResponse(true));
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
logger.LogError(ex, "An error occured logging out.");
|
||||
return BadRequest(new ApiResponse("An error occured logging out."));
|
||||
}
|
||||
return Ok(new ApiResponse(true));
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Compares the passwords in constant time (by comparing hashes, so differing lengths don't leak either).
|
||||
/// </summary>
|
||||
private static bool PasswordMatches(string? provided, string expected)
|
||||
{
|
||||
byte[] providedHash = SHA256.HashData(Encoding.UTF8.GetBytes(provided ?? string.Empty));
|
||||
byte[] expectedHash = SHA256.HashData(Encoding.UTF8.GetBytes(expected));
|
||||
return CryptographicOperations.FixedTimeEquals(providedHash, expectedHash);
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user