Harden backend auth, validation and error handling
- Rate limit login (5 attempts/min per IP) with a JSON 429 response - Constant-time password comparison; refuse login if no password is configured - Explicit SameSite=Strict auth cookie; log failed logins with client IP - Stop logging door codes (update log lines and the SMS body) - Replace per-action try/catch -> 400 with a global exception handler (JSON 500) - Return proper statuses: 404 for missing person, 502 for failed lock writes - Validate codes as ASCII digits only (int.TryParse accepted +/-/whitespace) - Validate person name and E.164 phone number; reject sending an unset code - Rename TwiloOptions -> TwilioOptions and fix message typos - Expose Program for integration tests
This commit is contained in:
1 parent
768bcc90e4
commit
d0425c8cb2
38 files changed
+189
-487
No files matched your search
@@ -5,23 +5,23 @@ using YaleAccess.Models.Options;
|
||||
|
||||
namespace YaleAccess.Services
|
||||
{
|
||||
public class SMSService(ILogger<SMSService> logger, IOptions<TwiloOptions> twiloOptions)
|
||||
public class SMSService(ILogger<SMSService> logger, IOptions<TwilioOptions> twilioOptions)
|
||||
{
|
||||
public async Task SendCodeViaSMSAsync(string code, string phoneNumber)
|
||||
{
|
||||
// Create a Twilio client
|
||||
TwilioClient.Init(twiloOptions.Value.AccountSid, twiloOptions.Value.AuthToken);
|
||||
TwilioClient.Init(twilioOptions.Value.AccountSid, twilioOptions.Value.AuthToken);
|
||||
|
||||
// Send the message
|
||||
var message = await MessageResource.CreateAsync(
|
||||
body: $"{twiloOptions.Value.Message} {code}",
|
||||
from: new Twilio.Types.PhoneNumber(twiloOptions.Value.FromNumber),
|
||||
body: $"{twilioOptions.Value.Message} {code}",
|
||||
from: new Twilio.Types.PhoneNumber(twilioOptions.Value.FromNumber),
|
||||
to: new Twilio.Types.PhoneNumber(phoneNumber)
|
||||
);
|
||||
|
||||
// Log the message
|
||||
// (the message body contains the door code, so it is deliberately not logged)
|
||||
logger.LogInformation("SMS sent to {PhoneNumber} with message SID {MessageSid}.", phoneNumber, message.Sid);
|
||||
logger.LogDebug("SMS message: {MessageBody}", message.Body);
|
||||
}
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user